Readme Opensearch Logo linking to non-existent file [CCI] #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timur Bolotov <[email protected]>
BSFishy
reviewed
Mar 7, 2023
README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
|  | |||
| <img src="https://opensearch.org/assets/img/opensearch-logo-themed.svg" height="64px"> | |||
There was a problem hiding this comment.
@KrooshalUX This should also have an alt attribute right?
There was a problem hiding this comment.
@KrooshalUX This should also have an
altattribute right?
It's a markdown link now with thealtattribute
There was a problem hiding this comment.
Please use "OpenSearch Dashboards" as the alt content. Thanks!
timursaurus
changed the title
Signed-off-by: Timur Bolotov <[email protected]>
timursaurus
changed the title
joshuarrrr
approved these changes
Mar 9, 2023
It's on my "to-do" list! |
BSFishy
approved these changes
Mar 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix: logo linking to non-existent file Signed-off-by: Timur Bolotov <[email protected]> * chore: use markdown link with alt text Signed-off-by: Timur Bolotov <[email protected]> --------- Signed-off-by: Timur Bolotov <[email protected]> (cherry picked from commit 2de51fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix: logo linking to non-existent file Signed-off-by: Timur Bolotov <[email protected]> * chore: use markdown link with alt text Signed-off-by: Timur Bolotov <[email protected]> --------- Signed-off-by: Timur Bolotov <[email protected]> (cherry picked from commit 2de51fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix: logo linking to non-existent file * chore: use markdown link with alt text --------- (cherry picked from commit 2de51fb) Signed-off-by: Timur Bolotov <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix: logo linking to non-existent file * chore: use markdown link with alt text --------- (cherry picked from commit 2de51fb) Signed-off-by: Timur Bolotov <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix changes the logo linking, as it was leading to a non-existent file. Instead, it uses the logo asset that is stored externally on the OpenSearch website.
Issues Resolved
Closes #564
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.